spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CodingCat <...@git.apache.org>
Subject [GitHub] spark pull request #19926: [SPARK-22733] Split StreamExecution into MicroBat...
Date Tue, 12 Dec 2017 18:55:36 GMT
Github user CodingCat commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19926#discussion_r156451593
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
    @@ -71,27 +68,29 @@ class StreamExecution(
     
       import org.apache.spark.sql.streaming.StreamingQueryListener._
     
    -  private val pollingDelayMs = sparkSession.sessionState.conf.streamingPollingDelay
    +  protected val pollingDelayMs: Long = sparkSession.sessionState.conf.streamingPollingDelay
     
    -  private val minBatchesToRetain = sparkSession.sessionState.conf.minBatchesToRetain
    +  protected val minBatchesToRetain: Int = sparkSession.sessionState.conf.minBatchesToRetain
       require(minBatchesToRetain > 0, "minBatchesToRetain has to be positive")
     
       /**
        * A lock used to wait/notify when batches complete. Use a fair lock to avoid thread
starvation.
        */
    -  private val awaitBatchLock = new ReentrantLock(true)
    -  private val awaitBatchLockCondition = awaitBatchLock.newCondition()
    +  protected val awaitProgressLock = new ReentrantLock(true)
    +  protected val awaitProgressLockCondition: Condition = awaitProgressLock.newCondition()
    --- End diff --
    
    do we really need explicitly typing here? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message