spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sethah <...@git.apache.org>
Subject [GitHub] spark pull request #19876: [WIP][ML][SPARK-11171][SPARK-11239] Add PMML expo...
Date Tue, 12 Dec 2017 14:58:40 GMT
Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19876#discussion_r156381361
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
    @@ -554,7 +555,49 @@ class LinearRegressionModel private[ml] (
        * This also does not save the [[parent]] currently.
        */
       @Since("1.6.0")
    -  override def write: MLWriter = new LinearRegressionModel.LinearRegressionModelWriter(this)
    +  override def write: GeneralMLWriter = new GeneralMLWriter(this)
    --- End diff --
    
    The doc above this is wrong.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message