spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smurakozi <...@git.apache.org>
Subject [GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...
Date Fri, 08 Dec 2017 19:11:14 GMT
Github user smurakozi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19920#discussion_r155852268
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala ---
    @@ -88,4 +90,8 @@ private[history] class HistoryPage(parent: HistoryServer) extends WebUIPage("")
       private def makePageLink(showIncomplete: Boolean): String = {
         UIUtils.prependBaseUri("/?" + "showIncomplete=" + showIncomplete)
       }
    +
    +  private def isApplicationCompleted(appInfo: ApplicationInfo): Boolean = {
    --- End diff --
    
    I've checked the status and the history packages and found no suitable object. 
    As it is only one extra copy of a tiny method and it's in test code I don't think it would
worth the extra complexity of introducing a new object, so I think it's best to leave it as
it is. 
    If we use it more frequently we can extract into a util object.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message