spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests
Date Wed, 06 Dec 2017 23:17:11 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19882#discussion_r155390445
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala
---
    @@ -0,0 +1,165 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.hive.orc
    +
    +import org.apache.spark.sql.AnalysisException
    +import org.apache.spark.sql.catalyst.catalog.HiveTableRelation
    +import org.apache.spark.sql.execution.datasources.{HadoopFsRelation, LogicalRelation}
    +import org.apache.spark.sql.execution.datasources.orc.OrcQueryTest
    +import org.apache.spark.sql.hive.HiveUtils
    +import org.apache.spark.sql.hive.test.TestHiveSingleton
    +import org.apache.spark.sql.internal.SQLConf
    +
    +class HiveOrcQuerySuite extends OrcQueryTest with TestHiveSingleton {
    +  import testImplicits._
    +
    +  override def orcImp: String = "hive"
    +
    +  test("SPARK-8501: Avoids discovery schema from empty ORC files") {
    --- End diff --
    
    This only works in new OrcFileFormat.
    - The new test case is in `OrcQuerySuite` for new OrcFileFormat.
    - And, the old test case is `HiveOrcQuerySuite` for old OrcFileFormat.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message