spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liyinan926 <...@git.apache.org>
Subject [GitHub] spark pull request #19717: [SPARK-22646] [Submission] Spark on Kubernetes - ...
Date Tue, 05 Dec 2017 19:11:09 GMT
Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19717#discussion_r155047041
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2744,6 +2744,25 @@ private[spark] object Utils extends Logging {
         }
       }
     
    +  /**
    +   * Check the validity of the given Kubernetes master URL and return the resolved URL.
    +   */
    +  def checkAndGetK8sMasterUrl(rawMasterURL: String): String = {
    +    require(rawMasterURL.startsWith("k8s://"),
    +      "Kubernetes master URL must start with k8s://.")
    +    val masterWithoutK8sPrefix = rawMasterURL.substring("k8s://".length)
    --- End diff --
    
    OK, did some changes to make all supported formats work. See https://github.com/apache/spark/pull/19717/commits/51844cc60753456cdf8c2d34a660c239a3c8aa13.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message