spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #19871: [SPARK-20728][SQL] Make OrcFileFormat configurabl...
Date Tue, 05 Dec 2017 07:18:53 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19871#discussion_r154862662
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
    @@ -568,8 +574,13 @@ object DataSource extends Logging {
         "org.apache.spark.Logging")
     
       /** Given a provider name, look up the data source class definition. */
    -  def lookupDataSource(provider: String): Class[_] = {
    -    val provider1 = backwardCompatibilityMap.getOrElse(provider, provider)
    +  def lookupDataSource(provider: String, conf: SQLConf): Class[_] = {
    +    val provider1 = backwardCompatibilityMap.getOrElse(provider, provider) match {
    +      case name if name.equalsIgnoreCase("orc") &&
    +          conf.getConf(SQLConf.ORC_IMPLEMENTATION) == "native" =>
    +        classOf[OrcFileFormat].getCanonicalName
    +      case name => name
    --- End diff --
    
    So, there is no more `The ORC data source must be used with Hive support enabled`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message