spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #19888: [SPARK-22686][SQL] DROP TABLE IF EXISTS should no...
Date Tue, 05 Dec 2017 06:35:34 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19888#discussion_r154857148
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -206,7 +206,8 @@ case class DropTableCommand(
         try {
           sparkSession.sharedState.cacheManager.uncacheQuery(sparkSession.table(tableName))
         } catch {
    -      case _: NoSuchTableException if ifExists =>
    +      case ae: AnalysisException
    +        if ifExists && ae.cause.nonEmpty && ae.getCause.isInstanceOf[NoSuchTableException]
=>
    --- End diff --
    
    Yep. It exists in master, too.
    I'll update like the example by @cloud-fan .


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message