spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #19870: [SPARK-22665][SQL] Avoid repartitioning with empt...
Date Mon, 04 Dec 2017 12:45:43 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19870#discussion_r154542257
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
    @@ -838,6 +838,8 @@ case class RepartitionByExpression(
         numPartitions: Int) extends RepartitionOperation {
     
       require(numPartitions > 0, s"Number of partitions ($numPartitions) must be positive.")
    +  require(partitionExpressions.nonEmpty, s"${getClass.getSimpleName} requires a non empty
set of " +
    +    s"partitioning expressions.")
    --- End diff --
    
    Let's remove this leading 's'.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message