spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #19871: [SPARK-20728][SQL] Make OrcFileFormat configurabl...
Date Mon, 04 Dec 2017 05:51:07 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19871#discussion_r154563532
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
    @@ -568,8 +570,13 @@ object DataSource extends Logging {
         "org.apache.spark.Logging")
     
       /** Given a provider name, look up the data source class definition. */
    -  def lookupDataSource(provider: String): Class[_] = {
    -    val provider1 = backwardCompatibilityMap.getOrElse(provider, provider)
    +  def lookupDataSource(sparkSession: SparkSession, provider: String): Class[_] = {
    +    var provider1 = backwardCompatibilityMap.getOrElse(provider, provider)
    +    if (Seq("orc", "org.apache.spark.sql.hive.orc.OrcFileFormat").contains(provider1.toLowerCase)
&&
    --- End diff --
    
    I see.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message