spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liyinan926 <...@git.apache.org>
Subject [GitHub] spark pull request #19717: [SPARK-22646] [Submission] Spark on Kubernetes - ...
Date Sun, 03 Dec 2017 21:40:27 GMT
Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19717#discussion_r154537691
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
    @@ -294,7 +301,9 @@ private[deploy] class SparkSubmitArguments(args: Seq[String], env:
Map[String, S
       }
     
       private def validateKillArguments(): Unit = {
    -    if (!master.startsWith("spark://") && !master.startsWith("mesos://")) {
    +    if (!master.startsWith("spark://")
    +      && !master.startsWith("mesos://")
    +      && !master.startsWith("k8s://")) {
           SparkSubmit.printErrorAndExit(
             "Killing submissions is only supported in standalone or Mesos mode!")
    --- End diff --
    
    Done.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message