Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: jkbradley <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-19208-spark@git.apache.org>
In-Reply-To: <git-pr-19208-spark@git.apache.org>
Subject: [GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...
Content-Type: text/plain
Message-Id: <20171113181418.674B5DFC49@git1-us-west.apache.org>
Date: Mon, 13 Nov 2017 18:14:18 +0000 (UTC)
archived-at: Mon, 13 Nov 2017 18:14:20 -0000

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19208#discussion_r150619165
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala ---
    @@ -265,23 +317,58 @@ class TrainValidationSplitModel private[ml] (
     @Since("2.0.0")
     object TrainValidationSplitModel extends MLReadable[TrainValidationSplitModel] {
     
    +  private[TrainValidationSplitModel] def copySubModels(subModels: Option[Array[Model[_]]])
    +    : Option[Array[Model[_]]] = {
    +    subModels.map(_.map(_.copy(ParamMap.empty).asInstanceOf[Model[_]]))
    +  }
    +
       @Since("2.0.0")
       override def read: MLReader[TrainValidationSplitModel] = new TrainValidationSplitModelReader
     
       @Since("2.0.0")
       override def load(path: String): TrainValidationSplitModel = super.load(path)
     
    -  private[TrainValidationSplitModel]
    -  class TrainValidationSplitModelWriter(instance: TrainValidationSplitModel) extends MLWriter {
    +  /**
    +   * Writer for TrainValidationSplitModel.
    +   * @param instance TrainValidationSplitModel instance used to construct the writer
    +   *
    +   * TrainValidationSplitModel supports an option "persistSubModels", with possible values
    +   * "true" or "false". If you set the collectSubModels Param before fitting, then you can
    +   * set "persistSubModels" to "true" in order to persist the subModels. By default,
    +   * "persistSubModels" will be "true" when subModels are available and "false" otherwise.
    +   * If subModels are not available, then setting "persistSubModels" to "true" will cause
    +   * an exception.
    +   */
    +  final class TrainValidationSplitModelWriter private[tuning] (
    --- End diff --
    
    Since annotation


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org