Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: viirya <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-19720-spark@git.apache.org>
In-Reply-To: <git-pr-19720-spark@git.apache.org>
Subject: [GitHub] spark pull request #19720: [SPARK-22494][SQL] Fix 64KB limit exception with ...
Content-Type: text/plain
Message-Id: <20171112104128.9BCE4DFDD1@git1-us-west.apache.org>
Date: Sun, 12 Nov 2017 10:41:28 +0000 (UTC)
archived-at: Sun, 12 Nov 2017 10:41:30 -0000

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19720#discussion_r150406351
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala ---
    @@ -90,7 +86,12 @@ case class Coalesce(children: Seq[Expression]) extends Expression {
               }
             }
           """
    -    }.mkString("\n"))
    +    }
    +
    +    ev.copy(code = s"""
    +      ${ev.isNull} = true;
    +      ${ev.value} = ${ctx.defaultValue(dataType)};
    +      ${ctx.splitExpressions(ctx.INPUT_ROW, evals)}""")
    --- End diff --
    
    It won't cause problem in fact. In that case, it works as before, i.e., `expressions.mkString("\n")`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org