Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: jinxing64 <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-19652-spark@git.apache.org>
In-Reply-To: <git-pr-19652-spark@git.apache.org>
Subject: [GitHub] spark pull request #19652: [SPARK-22435][SQL] Support processing array and m...
Content-Type: text/plain
Message-Id: <20171103130126.21529DFB6F@git1-us-west.apache.org>
Date: Fri,  3 Nov 2017 13:01:26 +0000 (UTC)
archived-at: Fri, 03 Nov 2017 13:01:30 -0000

Github user jinxing64 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19652#discussion_r148775355
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala ---
    @@ -267,6 +268,33 @@ private class ScriptTransformationWriterThread(
       /** Contains the exception thrown while writing the parent iterator to the external process. */
       def exception: Option[Throwable] = Option(_exception)
     
    +  private def buildJSONString(sb: StringBuilder, obj: Any): Unit = {
    --- End diff --
    
    TODO: build json string for more types


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org