spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request #19687: [SPARK-19644][SQL]Clean up Scala reflection garba...
Date Wed, 08 Nov 2017 00:37:46 GMT
GitHub user zsxwing opened a pull request:

    https://github.com/apache/spark/pull/19687

    [SPARK-19644][SQL]Clean up Scala reflection garbage after creating Encoder

    ## What changes were proposed in this pull request?
    
    Because of the memory leak issue in `scala.reflect.api.Types.TypeApi.<:<` (https://github.com/scala/bug/issues/8302),
creating an encoder may leak memory.
    
    This PR adds `cleanUpReflectionObjects` to clean up these leaking objects for methods
calling `scala.reflect.api.Types.TypeApi.<:<`.
    
    ## How was this patch tested?
    
    The updated unit tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zsxwing/spark SPARK-19644

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19687.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19687
    
----
commit c03811ff006058987fa8d5fb9f7d097b9acc9ac5
Author: Shixiong Zhu <zsxwing@gmail.com>
Date:   2017-11-08T00:33:55Z

    Clean up Scala reflection garbage after creating Encoder

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message