spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #19650: [SPARK-22254][core] Fix the arrayMax in BufferHol...
Date Fri, 03 Nov 2017 03:23:43 GMT
GitHub user kiszk opened a pull request:

    https://github.com/apache/spark/pull/19650

    [SPARK-22254][core] Fix the arrayMax in BufferHolder

    ## What changes were proposed in this pull request?
    
    This PR replaces the old the maximum array size (`Int.MaxValue`) with the new one (`ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH`).
    This PR also refactor the code to calculate the new array size to easily understand why
we have to use `newSize - 2` for allocating a new array.
    
    ## How was this patch tested?
    
    Used the existing test

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kiszk/spark SPARK-22254

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19650.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19650
    
----
commit 0a536fb0dbaa9e1e929610ecc15ac416253fd823
Author: Kazuaki Ishizaki <ishizaki@jp.ibm.com>
Date:   2017-11-03T03:14:00Z

    initial commit

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message