spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...
Date Thu, 30 Nov 2017 18:00:50 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19854#discussion_r154154076
  
    --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java ---
    @@ -169,8 +169,10 @@ public static ByteBuffer allocateDirectBuffer(int size) {
           cleanerField.setAccessible(true);
           long memory = allocateMemory(size);
           ByteBuffer buffer = (ByteBuffer) constructor.newInstance(memory, size);
    -      Cleaner cleaner = Cleaner.create(buffer, () -> freeMemory(memory));
    -      cleanerField.set(buffer, cleaner);
    +//    sun.misc.Cleaner is not used in JDK9(see SPARK-22659), we can use CleanUtil in
HADOOP-12760 to solve it
    +//    Cleaner cleaner = Cleaner.create(buffer, () -> freeMemory(memory));
    +//    cleanerField.set(buffer, cleaner);
    --- End diff --
    
    This change isn't valid and isn't related


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message