spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #19854: SPARK-22660:Use position() and limit() to fix amb...
Date Thu, 30 Nov 2017 17:01:27 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19854#discussion_r154138361
  
    --- Diff: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
    @@ -99,7 +99,7 @@ private[spark] class TorrentBroadcast[T: ClassTag](obj: T, id: Long)
       private def calcChecksum(block: ByteBuffer): Int = {
         val adler = new Adler32()
         if (block.hasArray) {
    -      adler.update(block.array, block.arrayOffset + block.position, block.limit - block.position)
    +      adler.update(block.array, block.arrayOffset + block.position(), block.limit() -
block.position())
    --- End diff --
    
    This exceeds 100 character length limit. See the logs in Jenkins tests.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message