spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jiangxb1987 <...@git.apache.org>
Subject [GitHub] spark pull request #19717: [SPARK-18278] [Submission] Spark on Kubernetes - ...
Date Mon, 27 Nov 2017 15:29:37 GMT
Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19717#discussion_r153101406
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -702,6 +715,18 @@ object SparkSubmit extends CommandLineUtils with Logging {
           }
         }
     
    +    if (isKubernetesCluster) {
    +      childMainClass = "org.apache.spark.deploy.k8s.submit.Client"
    +      childArgs ++= Array("--primary-java-resource", args.primaryResource)
    +      childArgs ++= Array("--main-class", args.mainClass)
    +      if (args.childArgs != null) {
    +        args.childArgs.foreach { arg =>
    +          childArgs += "--arg"
    --- End diff --
    
    Why not `childArgs += ("--arg", arg)`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message