spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #19792: [SPARK-22566][PYTHON] Better error message for `_...
Date Mon, 27 Nov 2017 08:32:47 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19792#discussion_r153130823
  
    --- Diff: python/pyspark/sql/types.py ---
    @@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
             return isinstance(dt, NullType)
     
     
    -def _merge_type(a, b):
    +def _merge_type(a, b, path=''):
    --- End diff --
    
    I really don't have a strong opinion on this. @ueshin do you maybe have a preference or
another option, or are you okay with the current format in general?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message