spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jiangxb1987 <...@git.apache.org>
Subject [GitHub] spark pull request #11994: [SPARK-14151] Expose metrics Source and Sink inte...
Date Mon, 27 Nov 2017 03:08:14 GMT
Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11994#discussion_r153097471
  
    --- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala ---
    @@ -195,18 +196,26 @@ private[spark] class MetricsSystem private (
           val classPath = kv._2.getProperty("class")
           if (null != classPath) {
             try {
    -          val sink = Utils.classForName(classPath)
    -            .getConstructor(classOf[Properties], classOf[MetricRegistry], classOf[SecurityManager])
    -            .newInstance(kv._2, registry, securityMgr)
    +          val sink = Utils.classForName(classPath).getConstructor(
    +            classOf[Properties], classOf[MetricRegistry], classOf[SecurityManager])
    --- End diff --
    
    Why make this format change?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message