spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #19767: [SPARK-22543][SQL] fix java 64kb compile error fo...
Date Wed, 22 Nov 2017 06:26:37 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19767#discussion_r152476972
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
    @@ -105,6 +105,36 @@ abstract class Expression extends TreeNode[Expression] {
           val isNull = ctx.freshName("isNull")
           val value = ctx.freshName("value")
           val ve = doGenCode(ctx, ExprCode("", isNull, value))
    +
    +      // TODO: support whole stage codegen too
    +      if (ve.code.trim.length > 1024 && ctx.INPUT_ROW != null && ctx.currentVars
== null) {
    --- End diff --
    
    Could you change `1024` to `1`? Just to ensure whether all the tests can pass?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message