spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #19778: [SPARK-22550][SQL] Fix 64KB JVM bytecode limit pr...
Date Tue, 21 Nov 2017 06:47:57 GMT
Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19778#discussion_r152190136
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
    @@ -841,6 +825,26 @@ class CodegenContext {
         }
       }
     
    +  def splitCodes(expressions: Seq[String]): Seq[String] = {
    --- End diff --
    
    Sure, but it is not `private`.  It is used in `stringExpressions`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message