spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...
Date Mon, 20 Nov 2017 12:36:47 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19783#discussion_r151979117
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/FilterEstimationSuite.scala
---
    @@ -158,8 +196,8 @@ class FilterEstimationSuite extends StatsEstimationTestBase {
         val condition = Not(And(LessThan(attrInt, Literal(3)), Literal(null, IntegerType)))
         validateEstimatedStats(
           Filter(condition, childStatsTestPlan(Seq(attrInt), 10L)),
    -      Seq(attrInt -> colStatInt.copy(distinctCount = 8)),
    -      expectedRowCount = 8)
    +      Seq(attrInt -> colStatInt.copy(distinctCount = 7)),
    --- End diff --
    
    +1


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message