spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From skonto <...@git.apache.org>
Subject [GitHub] spark pull request #19390: [SPARK-18935][MESOS] Fix dynamic reservations on ...
Date Fri, 17 Nov 2017 12:26:13 GMT
Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19390#discussion_r151673131
  
    --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
    @@ -451,15 +468,22 @@ trait MesosSchedulerUtils extends Logging {
       }
     
       /** Creates a mesos resource for a specific port number. */
    -  private def createResourcesFromPorts(portsAndRoles: List[(Long, String)]) : List[Resource]
= {
    -    portsAndRoles.flatMap{ case (port, role) =>
    -      createMesosPortResource(List((port, port)), Some(role))}
    +  private def createResourcesFromPorts(
    +       portsAndResourcesInfo: List[(Long, (String, AllocationInfo, Option[ReservationInfo]))])
    +    : List[Resource] = {
    +    portsAndResourcesInfo.flatMap{ case (port, rInfo) =>
    --- End diff --
    
    ok


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message