spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From icexelloss <...@git.apache.org>
Subject [GitHub] spark pull request #19630: [SPARK-22409] Introduce function type argument in...
Date Thu, 16 Nov 2017 15:35:21 GMT
Github user icexelloss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19630#discussion_r151448056
  
    --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
    @@ -34,9 +34,11 @@ import org.apache.spark.util._
      */
     private[spark] object PythonEvalType {
       val NON_UDF = 0
    -  val SQL_BATCHED_UDF = 1
    -  val SQL_PANDAS_UDF = 2
    -  val SQL_PANDAS_GROUPED_UDF = 3
    +
    +  val SQL_BATCHED_UDF = 100
    +
    +  val PANDAS_SCALAR_UDF = 200
    +  val PANDAS_GROUP_MAP_UDF = 201
    --- End diff --
    
    I don't mind changing it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message