spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #19730: [SPARK-22500][SQL] Fix 64KB JVM bytecode limit pr...
Date Mon, 13 Nov 2017 16:10:30 GMT
Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19730#discussion_r150584342
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
    @@ -1039,13 +1039,19 @@ case class Cast(child: Expression, dataType: DataType, timeZoneId:
Option[String
               }
             }
            """
    -    }.mkString("\n")
    +    }
    +    val fieldsEvalCodes = if (ctx.INPUT_ROW != null && ctx.currentVars == null)
{
    --- End diff --
    
    shouldn't be `ctx.currentVars != null`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message