spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #17631: [SPARK-20319][SQL] Already quoted identifiers are...
Date Sat, 11 Nov 2017 19:51:15 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17631#discussion_r150391984
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
    @@ -121,7 +121,8 @@ object JdbcUtils extends Logging {
           isCaseSensitive: Boolean,
           dialect: JdbcDialect): String = {
         val columns = if (tableSchema.isEmpty) {
    -      rddSchema.fields.map(x => dialect.quoteIdentifier(x.name)).mkString(",")
    +      rddSchema.fields.map(
    +        x => dialect.quoteIdentifier(x.name.stripPrefix("\"").stripSuffix("\""))).mkString(",")
    --- End diff --
    
    Different identifiers are using different quotes. We can do it in the `dialect.quoteIdentifier`.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message