spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request #19543: [SPARK-19606][MESOS] Support constraints in spark...
Date Sat, 11 Nov 2017 06:51:00 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19543#discussion_r150376571
  
    --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
---
    @@ -122,4 +122,11 @@ package object config {
             "Example: key1:val1,key2:val2")
           .stringConf
           .createOptional
    +
    +  private[spark] val DRIVER_CONSTRAINTS =
    +    ConfigBuilder("spark.mesos.driver.constraints")
    +      .doc("Attribute based constraints on mesos resource offers. Applied by the dispatcher
" +
    +        "when launching drivers. Default is to accept all offers with sufficient resources.")
    +      .stringConf
    +      .createWithDefault("")
    --- End diff --
    
    should this be default to ""? looks like it might still match something
    https://github.com/apache/spark/blob/fc45c2c88a838b8f46659ebad2a8f3a9923bc95f/resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala#L267


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message