spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #19156: [SPARK-19634][SQL][ML][FOLLOW-UP] Improve interfa...
Date Wed, 08 Nov 2017 11:22:09 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19156#discussion_r149641398
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala ---
    @@ -94,46 +97,86 @@ object Summarizer extends Logging {
        *  - min: the minimum for each coefficient.
        *  - normL2: the Euclidian norm for each coefficient.
        *  - normL1: the L1 norm of each coefficient (sum of the absolute values).
    -   * @param firstMetric the metric being provided
    -   * @param metrics additional metrics that can be provided.
    +   * @param metrics metrics that can be provided.
        * @return a builder.
        * @throws IllegalArgumentException if one of the metric names is not understood.
        *
        * Note: Currently, the performance of this interface is about 2x~3x slower then using
the RDD
        * interface.
        */
       @Since("2.3.0")
    -  def metrics(firstMetric: String, metrics: String*): SummaryBuilder = {
    -    val (typedMetrics, computeMetrics) = getRelevantMetrics(Seq(firstMetric) ++ metrics)
    +  def metrics(metrics: String*): SummaryBuilder = {
    --- End diff --
    
    have you tried about java? IIRC this style is for java compatibility.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message