spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "...
Date Tue, 07 Nov 2017 16:05:42 GMT
Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17436#discussion_r149418567
  
    --- Diff: core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
    @@ -43,12 +43,13 @@ class StaticMemoryManagerSuite extends MemoryManagerSuite {
     
       override protected def createMemoryManager(
           maxOnHeapExecutionMemory: Long,
    -      maxOffHeapExecutionMemory: Long): StaticMemoryManager = {
    +      maxOffHeapExecutionMemory: Long = 1000): StaticMemoryManager = {
         new StaticMemoryManager(
           conf.clone
             .set("spark.memory.fraction", "1")
             .set("spark.testing.memory", maxOnHeapExecutionMemory.toString)
    -        .set("spark.memory.offHeap.size", maxOffHeapExecutionMemory.toString),
    +        .set("spark.memory.offHeap.size",
    --- End diff --
    
    To add `= 1000` is intentional and necessary.  
    If the original line is used, `spark.memory.offHeap.size` is zero even in the case `spark.memory.offHeap.enabled
== true`. This is because the caller sites do not pass the second argument and then the default
value `(= 0)` is used.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message