spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinxing64 <...@git.apache.org>
Subject [GitHub] spark pull request #19652: [SPARK-22435][SQL] Support processing array and m...
Date Fri, 03 Nov 2017 13:01:26 GMT
Github user jinxing64 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19652#discussion_r148775355
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala
---
    @@ -267,6 +268,33 @@ private class ScriptTransformationWriterThread(
       /** Contains the exception thrown while writing the parent iterator to the external
process. */
       def exception: Option[Throwable] = Option(_exception)
     
    +  private def buildJSONString(sb: StringBuilder, obj: Any): Unit = {
    --- End diff --
    
    TODO: build json string for more types


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message