spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #19648: [SPARK-14516][ML][FOLLOW-UP] Move ClusteringEvalu...
Date Fri, 03 Nov 2017 09:20:30 GMT
Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19648#discussion_r148734734
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/evaluation/ClusteringEvaluatorSuite.scala
---
    @@ -22,15 +22,21 @@ import org.apache.spark.ml.param.ParamsSuite
     import org.apache.spark.ml.util.DefaultReadWriteTest
     import org.apache.spark.ml.util.TestingUtils._
     import org.apache.spark.mllib.util.MLlibTestSparkContext
    -import org.apache.spark.sql.{DataFrame, SparkSession}
    -import org.apache.spark.sql.types.IntegerType
    +import org.apache.spark.sql.Dataset
     
     
     class ClusteringEvaluatorSuite
       extends SparkFunSuite with MLlibTestSparkContext with DefaultReadWriteTest {
     
       import testImplicits._
     
    +  @transient var irisDataset: Dataset[_] = _
    --- End diff --
    
    what about using a `lazy val` instead of initializing it `beforeAll` method?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message