spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hhbyyh <...@git.apache.org>
Subject [GitHub] spark pull request #19588: [SPARK-12375][ML] VectorIndexerModel support hand...
Date Thu, 02 Nov 2017 07:30:47 GMT
Github user hhbyyh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19588#discussion_r148442709
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/VectorIndexer.scala ---
    @@ -287,9 +315,12 @@ class VectorIndexerModel private[ml] (
         while (featureIndex < numFeatures) {
           if (categoryMaps.contains(featureIndex)) {
             // categorical feature
    -        val featureValues: Array[String] =
    +        var featureValues: Array[String] =
    --- End diff --
    
    minor: this can still be a val with if else, right?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message