spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark pull request #19624: [SPARKR][SPARK-22315] Warn if SparkR package vers...
Date Wed, 01 Nov 2017 17:02:02 GMT
Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19624#discussion_r148320092
  
    --- Diff: R/pkg/R/sparkR.R ---
    @@ -420,6 +420,18 @@ sparkR.session <- function(
                                     enableHiveSupport)
         assign(".sparkRsession", sparkSession, envir = .sparkREnv)
       }
    +
    +  # Check if version number of SparkSession matches version number of SparkR package
    +  jvmVersion <- callJMethod(sparkSession, "version")
    +  # Remove -SNAPSHOT from jvm versions
    +  jvmVersion <- gsub("-SNAPSHOT", "", jvmVersion)
    +  rPackageVersion <- paste0(packageVersion("SparkR"))
    +
    +  if (jvmVersion != rPackageVersion) {
    +    warning(paste("Version mismatch between Spark JVM and SparkR package. JVM version
was",
    +                  jvmVersion, ", while R package version was", rPackageVersion))
    --- End diff --
    
    I wonder if that would be more confusing as somebody might think they just need to remove
the `-snapshot` ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message