Return-Path: <reviews-return-577559-archive-asf-public=cust-asf.ponee.io@spark.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 43910200D2E
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 31 Oct 2017 18:19:40 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 423821609EF; Tue, 31 Oct 2017 17:19:40 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id B0D3B1609E6
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 31 Oct 2017 18:19:39 +0100 (CET)
Received: (qmail 69024 invoked by uid 500); 31 Oct 2017 17:19:39 -0000
Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@spark.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@spark.apache.org>
List-Post: <mailto:reviews@spark.apache.org>
List-Id: <reviews.spark.apache.org>
Delivered-To: mailing list reviews@spark.apache.org
Received: (qmail 69011 invoked by uid 99); 31 Oct 2017 17:19:38 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Oct 2017 17:19:38 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 95DCFDFBCA; Tue, 31 Oct 2017 17:19:38 +0000 (UTC)
From: dongjoon-hyun <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-19622-spark@git.apache.org>
In-Reply-To: <git-pr-19622-spark@git.apache.org>
Subject: [GitHub] spark pull request #19622: [SPARK-22306][SQL][2.2] alter table schema should...
Content-Type: text/plain
Message-Id: <20171031171938.95DCFDFBCA@git1-us-west.apache.org>
Date: Tue, 31 Oct 2017 17:19:38 +0000 (UTC)
archived-at: Tue, 31 Oct 2017 17:19:40 -0000

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19622#discussion_r148067066
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala ---
    @@ -837,20 +849,7 @@ private[hive] object HiveClientImpl {
         val (partCols, schema) = table.schema.map(toHiveColumn).partition { c =>
           table.partitionColumnNames.contains(c.getName)
         }
    -    // after SPARK-19279, it is not allowed to create a hive table with an empty schema,
    -    // so here we should not add a default col schema
    -    if (schema.isEmpty && HiveExternalCatalog.isDatasourceTable(table)) {
    -      // This is a hack to preserve existing behavior. Before Spark 2.0, we do not
    -      // set a default serde here (this was done in Hive), and so if the user provides
    -      // an empty schema Hive would automatically populate the schema with a single
    -      // field "col". However, after SPARK-14388, we set the default serde to
    -      // LazySimpleSerde so this implicit behavior no longer happens. Therefore,
    -      // we need to do it in Spark ourselves.
    -      hiveTable.setFields(
    -        Seq(new FieldSchema("col", "array<string>", "from deserializer")).asJava)
    -    } else {
    -      hiveTable.setFields(schema.asJava)
    -    }
    +    hiveTable.setFields(schema.asJava)
         hiveTable.setPartCols(partCols.asJava)
         userName.foreach(hiveTable.setOwner)
    --- End diff --
    
    @cloud-fan . `owner` seems to be changed here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org