Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: srowen <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-19586-spark@git.apache.org>
In-Reply-To: <git-pr-19586-spark@git.apache.org>
Subject: [GitHub] spark pull request #19586: [SPARK-22367][CORE] Separate the serialization of...
Content-Type: text/plain
Message-Id: <20171027100736.1DF09DFBAA@git1-us-west.apache.org>
Date: Fri, 27 Oct 2017 10:07:36 +0000 (UTC)
archived-at: Fri, 27 Oct 2017 10:07:38 -0000

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19586#discussion_r147371549
  
    --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
    @@ -205,11 +205,45 @@ class KryoSerializationStream(
     
       private[this] var kryo: Kryo = serInstance.borrowKryo()
     
    +  // This is only used when we write object and class separately.
    +  var classWrote = false
    --- End diff --
    
    Why not write that state as an iterator of stuff, if that's how it behaves? rather than duplicate code. 'values' is already an iterator there.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org