Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: wzhfy <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-17100-spark@git.apache.org>
In-Reply-To: <git-pr-17100-spark@git.apache.org>
Subject: [GitHub] spark pull request #17100: [SPARK-13947][SQL] The error message from using a...
Content-Type: text/plain
Message-Id: <20171024123039.95F01DFA3C@git1-us-west.apache.org>
Date: Tue, 24 Oct 2017 12:30:39 +0000 (UTC)
archived-at: Tue, 24 Oct 2017 12:30:41 -0000

Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17100#discussion_r146543299
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ---
    @@ -270,12 +270,25 @@ trait CheckAnalysis extends PredicateHelper {
     
             operator match {
               case o if o.children.nonEmpty && o.missingInput.nonEmpty =>
    +            val resolver = plan.conf.resolver
    +            val attrsWithSameName = o.missingInput.filter { missing =>
    +              o.inputSet.exists(input => resolver(missing.name, input.name))
    +            }
    +            val repeatedNameHint = if (attrsWithSameName.nonEmpty) {
    +              val sameNames = attrsWithSameName.map(_.name).mkString(",")
    +              s"""Attribute(s) with the same name appear in the operation: `$sameNames`.
    +                  |Please check if the right attribute(s) are used.""".stripMargin
    --- End diff --
    
    Personally I prefer one line message because it's an parameter of `AnalysisException`, but that's not a strong point.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org