Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1A649200D20 for ; Tue, 17 Oct 2017 23:56:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 190E21609EB; Tue, 17 Oct 2017 21:56:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 54EB21609D9 for ; Tue, 17 Oct 2017 23:56:07 +0200 (CEST) Received: (qmail 95670 invoked by uid 500); 17 Oct 2017 21:56:06 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 95659 invoked by uid 99); 17 Oct 2017 21:56:06 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Oct 2017 21:56:06 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2ABECDFB3D; Tue, 17 Oct 2017 21:56:06 +0000 (UTC) From: gatorsmile To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #19522: [SPARK-22249][FOLLOWUP][SQL] Check if list of val... Content-Type: text/plain Message-Id: <20171017215606.2ABECDFB3D@git1-us-west.apache.org> Date: Tue, 17 Oct 2017 21:56:06 +0000 (UTC) archived-at: Tue, 17 Oct 2017 21:56:08 -0000 Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19522#discussion_r145267736 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -176,6 +176,8 @@ object ReorderAssociativeOperator extends Rule[LogicalPlan] { object OptimizeIn extends Rule[LogicalPlan] { def apply(plan: LogicalPlan): LogicalPlan = plan transform { case q: LogicalPlan => q transformExpressionsDown { + case expr @ In(v, _) if expr.isListEmpty => --- End diff -- Update the comment in the rule. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org