spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #19551: [WIP][SPARK-17902][R] Revive stringsAsFactors opt...
Date Sun, 22 Oct 2017 10:37:18 GMT
GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/19551

    [WIP][SPARK-17902][R] Revive stringsAsFactors option for collect() in SparkR

    ## What changes were proposed in this pull request?
    
    This PR proposes to revive `stringsAsFactors` option in collect API, which was mistakenly
removed in https://github.com/apache/spark/commit/71a138cd0e0a14e8426f97877e3b52a562bbd02c.
    
    Simply, it casts `charactor` to `factor` if it meets the condition, `stringsAsFactors
&& is.character(vec)` in primitive type conversion.
    
    ## How was this patch tested?
    
    Unit test in `R/pkg/tests/fulltests/test_sparkSQL.R`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark SPARK-17902

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19551.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19551
    
----
commit ffe751bfbdae6d2bd4c127794ff2f6554d64bf3c
Author: hyukjinkwon <gurwls223@gmail.com>
Date:   2017-10-22T10:31:20Z

    Revive stringsAsFactors option for collect() in SparkR

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message