spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #19585: [TRIVIAL] [SQL] Code cleaning in ResolveReference...
Date Fri, 27 Oct 2017 21:27:33 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19585#discussion_r147520400
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -841,15 +852,7 @@ class Analyzer(
     
           case q: LogicalPlan =>
             logTrace(s"Attempting to resolve ${q.simpleString}")
    -        q.transformExpressionsUp  {
    --- End diff --
    
    can you provide more context here? The previous code resolve reference bottom-up, so that
we can resolve `a.b.c.d` with one round. The new code changes to top-down, why?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message