spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #19586: [SPARK-22367][CORE] Separate the serialization of...
Date Fri, 27 Oct 2017 10:07:36 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19586#discussion_r147371549
  
    --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
    @@ -205,11 +205,45 @@ class KryoSerializationStream(
     
       private[this] var kryo: Kryo = serInstance.borrowKryo()
     
    +  // This is only used when we write object and class separately.
    +  var classWrote = false
    --- End diff --
    
    Why not write that state as an iterator of stuff, if that's how it behaves? rather than
duplicate code. 'values' is already an iterator there.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message