spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akopich <...@git.apache.org>
Subject [GitHub] spark issue #19565: [SPARK-22111][MLLIB] OnlineLDAOptimizer should filter ou...
Date Thu, 26 Oct 2017 17:33:17 GMT
Github user akopich commented on the issue:

    https://github.com/apache/spark/pull/19565
  
    @hhbyyh, in case of "filter before sample" in a local test the overhead is negligible.

    
    Regarding "sample before filter", you are right. There (strictly speaking) should be adjustment
of `miniBatchFraction`. Which is why I do prefer "filter before sample".
    
    Also note, version "sample before filter" is logically equivalent to the current upstream/master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message