spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From skonto <...@git.apache.org>
Subject [GitHub] spark pull request #19390: [SPARK-18935][MESOS] Fix dynamic reservations on ...
Date Thu, 26 Oct 2017 09:21:40 GMT
Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19390#discussion_r147087405
  
    --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
    @@ -349,13 +349,22 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
           val offerMem = getResource(offer.getResourcesList, "mem")
           val offerCpus = getResource(offer.getResourcesList, "cpus")
           val offerPorts = getRangeResource(offer.getResourcesList, "ports")
    +      val offerAllocationInfo = offer.getAllocationInfo
    +      val offerReservationInfo = offer
    +        .getResourcesList
    +        .asScala
    +        .find(resource => Option(resource.getReservation).isDefined)
    --- End diff --
    
    I had it that why before but it is repeated in two places so I thought to make it a method.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message