spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdblue <>
Subject [GitHub] spark pull request #19568: SPARK-22345: Fix sort-merge joins with conditions...
Date Wed, 25 Oct 2017 20:22:21 GMT
Github user rdblue commented on a diff in the pull request:
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
    @@ -585,21 +585,26 @@ case class SortMergeJoinExec(
         val iterator = ctx.freshName("iterator")
         val numOutput = metricTerm(ctx, "numOutputRows")
    +    val joinedRow = ctx.freshName("joined")
    --- End diff --
    The second problem was fixed in this commit:
    I still think that the codegen problem should be fixed. Detecting `CodgenFallback` is
imperfect, but will still generate code and run it. I think we should either remove codegen
from `CodegenFallback` or add this fix to ensure that code works, even if we don't expect
to run it.


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message