spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #19556: [SPARK-22328][Core] ClosureCleaner should not mis...
Date Tue, 24 Oct 2017 11:50:54 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19556#discussion_r146534666
  
    --- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
    @@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
         (seen - obj.getClass).toList
       }
     
    +  /** Initializes the accessed fields for outer classes and their super classes. */
    +  private def initAccessedFields(
    +      accessedFields: Map[Class[_], Set[String]],
    +      outerClasses: Seq[Class[_]]): Unit = {
    --- End diff --
    
    what if multiple outer classes have the same parent class?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message