spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ArtRand <...@git.apache.org>
Subject [GitHub] spark pull request #19390: [SPARK-18935][MESOS] Fix dynamic reservations on ...
Date Tue, 17 Oct 2017 01:39:08 GMT
Github user ArtRand commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19390#discussion_r145010250
  
    --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
    @@ -469,6 +474,12 @@ trait MesosSchedulerUtils extends Logging {
             .setType(Value.Type.RANGES)
             .setRanges(Value.Ranges.newBuilder().addRange(rangeValue))
           role.foreach(r => builder.setRole(r))
    +
    +      if (role.forall(r => !r.equals("*"))) {
    --- End diff --
    
    Oh, I thought you could put the whole block into a function, that way if we need to change
the way we do the protos some day it's easy to change in one place. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message