spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark issue #19497: [SPARK-21549][CORE] Respect OutputFormats with no/invali...
Date Mon, 16 Oct 2017 02:16:36 GMT
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19497
  
    @mridulm, BTW, WDYT about disallowing:
    
    ```
    .saveAsNewAPIHadoopFile[...]("")
    .saveAsNewAPIHadoopFile[...]("::invalid:::")
    ```
    
    within the APIs? If i tested this correctly, this PR also allows both cases but I think
we should disallow as it requires `path` and overrides it and `saveAsHadoopFile` disallows
it. Seems this is also allowed in branch-2.1 as I recall correctly but looks disallowing it
sounds more making sense in any event.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message