spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tejasapatil <...@git.apache.org>
Subject [GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...
Date Fri, 13 Oct 2017 03:05:04 GMT
Github user tejasapatil commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19222#discussion_r144457118
  
    --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java
---
    @@ -17,47 +17,168 @@
     
     package org.apache.spark.unsafe.memory;
     
    -import javax.annotation.Nullable;
    -
     import org.apache.spark.unsafe.Platform;
     
    +import javax.annotation.Nullable;
    +
     /**
    - * A consecutive block of memory, starting at a {@link MemoryLocation} with a fixed size.
    + * A declaration of interfaces of MemoryBlock classes .
      */
    -public class MemoryBlock extends MemoryLocation {
    +public abstract class MemoryBlock {
    +  @Nullable
    +  protected final Object obj;
     
    -  private final long length;
    +  protected final long offset;
    +
    +  protected final long length;
     
       /**
        * Optional page number; used when this MemoryBlock represents a page allocated by
a
    -   * TaskMemoryManager. This field is public so that it can be modified by the TaskMemoryManager,
    -   * which lives in a different package.
    +   * TaskMemoryManager. This field can be updated using setPageNumber method so that
    --- End diff --
    
    typo: `TaskMemoryManager`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message