spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #19480: [SPARK-22226][SQL] splitExpression can create too...
Date Fri, 13 Oct 2017 02:21:22 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19480#discussion_r144452862
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
    @@ -1010,6 +1079,8 @@ object CodeGenerator extends Logging {
       // This is the value of HugeMethodLimit in the OpenJDK JVM settings
       val DEFAULT_JVM_HUGE_METHOD_LIMIT = 8000
     
    +  val MERGE_SPLIT_METHODS_THRESHOLD = 3
    --- End diff --
    
    Another magic number?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message