spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gengliangwang <...@git.apache.org>
Subject [GitHub] spark pull request #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule
Date Wed, 11 Oct 2017 21:09:42 GMT
Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19451#discussion_r144136954
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceOperatorSuite.scala
---
    @@ -50,6 +52,25 @@ class ReplaceOperatorSuite extends PlanTest {
         comparePlans(optimized, correctAnswer)
       }
     
    +  test("replace Except with Filter") {
    --- End diff --
    
    consider add a case that left child is not filter


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message